Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All of the IE11 bugs #47

Closed
grug opened this issue Jan 22, 2020 · 6 comments
Closed

All of the IE11 bugs #47

grug opened this issue Jan 22, 2020 · 6 comments

Comments

@grug
Copy link
Owner

grug commented Jan 22, 2020

Describe the bug
This library doesn't work with IE11 at all. This is due to the right polyfills not existing.

To Reproduce

  1. Create a new project with data-mocks included
  2. Attempt to load up a page that uses data-mocks in IE11
  3. Observe a million console errors

Expected behavior
That this library works as intended with IE11

Additional context
There will need to be a fair few polyfills added for this :(

@github-actions
Copy link

This issue hasn't received any attention in a while. Can it be closed or does it require more work?

@Dinosys
Copy link
Contributor

Dinosys commented May 22, 2020

it would still be nice if we could use this library in IE11...

@grug
Copy link
Owner Author

grug commented May 22, 2020

@Dinosys I'll see if I can give this a look today!

@grug grug reopened this May 22, 2020
@kieran-allen kieran-allen self-assigned this May 22, 2020
@kieran-allen
Copy link
Collaborator

kieran-allen commented May 22, 2020

I've got this working in a clean create-react-app project. I had to add the following polyfills to the project to get it working on ie11 without data-mocks included:

import "react-app-polyfill/ie11";
import "react-app-polyfill/stable";

However the only error I could attribute to data-mocks was Proxy is undefined which was caused by the fetch-mock library using Proxy which is unsupported by ie11.

This can be solved by a rollback to fetch-mock 6.5.2
wheresrhys/fetch-mock#415 (comment)

Definitely not seeing loads of console errors though.

N.B I've yet to test graphQL

@github-actions
Copy link

Hi there :) This issue hasn't received any attention in a while. Can it be closed or does it require more work?

@Lapz
Copy link

Lapz commented Jul 28, 2020

I've looked into IE11 and gotten this working and the main things that are needed are proxy-polyfill and the fetch-polyfill. The fetch-mock compatibility problems were [fixed]((JakeChampion/fetch#736) so IE 11 support should work out of the box. I've also created a repo that has the minimum changes needed for a CRA repo.

@github-actions github-actions bot closed this as completed Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants