Merge pull request #188 from kevva/fix

Fix empty images getting written
gruntjs · Apr 1, 2014 · b155dcb · b155dcb
2 parents f04bbc3 + 40d32ee
commit b155dcb
Showing 1 changed file with 19 additions and 20 deletions.
diff --git a/tasks/imagemin.js b/tasks/imagemin.js
@@ -27,35 +27,34 @@ module.exports = function (grunt) {
         });
 
         async.forEachLimit(files, os.cpus().length, function (file, next) {
+            var msg;
             options.ext = path.extname(file.src[0]);
 
             // filter out dirs
             if (!options.ext) {
                 return next();
             }
 
-            mkdirp(path.dirname(file.dest), function () {
-                var msg;
+            mkdirp.sync(path.dirname(file.dest));
 
-                fs.createReadStream(file.src[0])
-                    .pipe(imagemin(options)
-                        .on('error', grunt.warn.bind(grunt))
-                        .on('close', function (data) {
-                            totalSaved += data.diffSizeRaw;
+            fs.createReadStream(file.src[0])
+                .pipe(imagemin(options)
+                    .on('error', grunt.warn.bind(grunt))
+                    .on('close', function (data) {
+                        totalSaved += data.diffSizeRaw;
 
-                            if (data.diffSizeRaw < 10) {
-                                msg = 'already optimized';
-                            } else {
-                                msg = 'saved ' + data.diffSize + ' - ' + (data.diffSizeRaw / data.origSizeRaw * 100).toFixed() + '%';
-                            }
-                        }))
-                    .pipe(fs.createWriteStream(file.dest)
-                        .on('error', grunt.warn.bind(grunt))
-                        .on('close', function () {
-                            grunt.log.writeln(chalk.green('✔ ') + file.src[0] + chalk.gray(' (' + msg + ')'));
-                            next();
-                        }));
-            });
+                        if (data.diffSizeRaw < 10) {
+                            msg = 'already optimized';
+                        } else {
+                            msg = 'saved ' + data.diffSize + ' - ' + (data.diffSizeRaw / data.origSizeRaw * 100).toFixed() + '%';
+                        }
+                    }))
+                .pipe(fs.createWriteStream(file.dest)
+                    .on('error', grunt.warn.bind(grunt))
+                    .on('close', function () {
+                        grunt.log.writeln(chalk.green('✔ ') + file.src[0] + chalk.gray(' (' + msg + ')'));
+                        process.nextTick(next);
+                    }));
         }, function (err) {
             if (err) {
                 grunt.warn(err);