Don't require image bin deps till necessary

[nschonni]

Related to gh-123

[sindresorhus]

What's the problem? And you need to show some numbers.

[nschonni]

The problem/solution is from @cowboy #123 (comment)
Sorry for the lack of stats, but I got bitten with that issue with time-grunt no longer functioning with the latest Grunt release.

The test target in this repo will not show the benefit For those repos only using one or two of the optimizers, they will not get the penalty of requiring the bin just to resolve a path they won't use.

[shama]

Just did a quick benchmark with this. Seems a bit faster:

shama in ~/Documents/www/grunt-contrib/imagemin on master*
$ time grunt imagemin
Running "imagemin:dist" (imagemin) task
✔ test/fixtures/test.png (saved 10.14 kB)
✔ test/fixtures/test.jpg (saved 5.86 kB)
✔ test/fixtures/test.gif (saved 7 B)
✔ test/fixtures/test-uppercase.PNG (saved 10.14 kB)
✔ test/fixtures/test-uppercase.JPG (saved 5.86 kB)
✔ test/fixtures/test-uppercase.GIF (saved 7 B)
Minified 6 images (saved 32.01 kB)

Done, without errors.

real    0m1.623s
user    0m1.383s
sys 0m0.174s

shama in ~/Documents/www/grunt-contrib/imagemin on nschonni/lazy-require-deps*
$ time grunt imagemin
Running "imagemin:dist" (imagemin) task
✔ test/fixtures/test.png (saved 10.14 kB)
✔ test/fixtures/test.jpg (saved 5.86 kB)
✔ test/fixtures/test.gif (saved 7 B)
✔ test/fixtures/test-uppercase.PNG (saved 10.14 kB)
✔ test/fixtures/test-uppercase.JPG (saved 5.86 kB)
✔ test/fixtures/test-uppercase.GIF (saved 7 B)
Minified 6 images (saved 32.01 kB)

Done, without errors.

real    0m0.463s
user    0m0.412s
sys 0m0.054s

[nschonni]

Thanks @shama !

[nschonni]

@sindresorhus anything else to change for this?

[kevva]

@nschonni, this module is being rewritten (#97). The core has moved to https://github.com/kevva/image-min. Maybe we can change it there.

[nschonni]

@kevva I think the rewrite is a good idea, and this can definitely be upstreamed. I'd just like to see this land before that so people can get the benefit now.

[nschonni]

@sindresorhus should I close this

[sindresorhus]

@nschonni can you open a ticket on https://github.com/kevva/image-min/issues about fixing the actual loading speed problem?

[nschonni]

@kevva already did the same thing a few weeks ago https://github.com/kevva/image-min/blob/master/imagemin.js#L93 or where you thinking about a general performance issue?

[sindresorhus]

@nschonni i'd rather figure out why it's so slow to load.