Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pull request template with check re: exclusions #375

Merged
merged 1 commit into from
Nov 1, 2022
Merged

Update pull request template with check re: exclusions #375

merged 1 commit into from
Nov 1, 2022

Conversation

zackproser
Copy link
Contributor

Description

Fixes #374 .

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added / Removed / Updated [X].

Migration Guide

@zackproser
Copy link
Contributor Author

Thanks for review! Going to merge this in now.

@zackproser zackproser merged commit de17da2 into master Nov 1, 2022
@zackproser zackproser deleted the chore/374-update-pr-template branch November 1, 2022 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellisonc ellisonc ellisonc approved these changes

@denis256 denis256 Awaiting requested review from denis256 denis256 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update pull request template with checklist item for test account exclusions
2 participants
@zackproser @ellisonc