Introduce eks sync-core-components subcommand
#96
Conversation
|
NOTE: there are no tests for the command because it is expensive to launch and manage an EKS cluster. Instead, we rely on our EKS repo for integration testing. The related integration testing is being done here: https://github.com/gruntwork-io/terraform-aws-eks/pull/206 |
|
|
eks/sync.go
Outdated
| // Figure out the manifest URL based on region | ||
| // Reference: https://docs.aws.amazon.com/eks/latest/userguide/update-cluster.html | ||
| if strings.HasPrefix(region, "cn-") { | ||
| manifestPath = fmt.Sprintf("https://raw.githubusercontent.com/aws/amazon-vpc-cni-k8s/release-%s/config/v%s/aws-k8s-cni-cn.yaml", vpcCNIVersion, vpcCNIVersion) |
There was a problem hiding this comment.
NIT: It might be slightly more DRY and readable to Sprintf the URL once, like:
awsK8sCNIURL := fmt.Sprintf("https://raw.githubusercontent.com/aws/amazon-vpc-cni-k8s/release-%s/config/v%s/", vpcCNIVersion, vpcCNIVersion)
if strings.HasPrefix(region, "cn-") {
manifestPath = awsK8sCNIURL + "aws-k8s-cni-cn.yaml"
} else if region == "us-gov-east-1" {
... etc etc ...
}
There was a problem hiding this comment.
Ah good point! Updated: 87ea8c4
Co-authored-by: Ben Whaley <bwhaley@gmail.com>
|
Ping: this is ready for rereview. |
|
Thanks for review! Merging and releasing now!
No worries! This wasn't urgent anyway. I was going to have fun to see how long it would take by repeating |
This implements the logic in https://docs.aws.amazon.com/eks/latest/userguide/update-cluster.html , which we currently use a python script baked in the EKS module for. By moving the logic to
kubergrunt, we not only make the module more flexible (e.g., you don't need to update to latest version everytime a new k8s version is released), but the logic can also be used with other methods of launching EKS, including the open source tf module.See https://github.com/gruntwork-io/terraform-aws-eks/issues/174 for more details.