Skip to content

Commit

Permalink
update _pkgdown and cran-comments [skip ci]
Browse files Browse the repository at this point in the history
  • Loading branch information
zkamvar committed Mar 15, 2018
1 parent 36b9fe7 commit 5374669
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 24 deletions.
1 change: 1 addition & 0 deletions _pkgdown.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ reference:
contents:
- as.genclone # (m) - Converts genind objects to genclone objects
- as.snpclone
- as.genambig
- missingno # (m) - Handles missing data
- clonecorrect # (m | s) - Clone-censors at a specified population hierarchy
- informloci # (m) - Detects and removes phylogenetically uninformative loci
Expand Down
26 changes: 2 additions & 24 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,37 +1,15 @@
# Poppr version 2.6.1

This version fixes a heap-buffer-overflow in clang-ASAN. Details of the fix are documented at https://github.com/grunwaldlab/poppr/issues/169
This version exposes two new functions to users and fixes a bug.

## Test environments

* local OS X install, R 3.4.3
* ubuntu 12.04 (on travis-ci), devel (2018-01-13 r74115) and R 3.4.3
* ubuntu 12.04 (on travis-ci), devel (2018-03-15 r74411) and R 3.4.3
* winbuilder R-devel (2018-01-13 r74113)

## R CMD check results

## clang-ASAN

The not currently on cran is fixed in this version.

## valgrind

There is currently a valgrind note on CRAN. I believe this fix addresses all the locations that were originally flagged in this comment.

It was brought up on 2016-06-08. I responded on 2016-06-09:

> It was my understanding that this was an artifact due to the behavior of OpenMP and valgrind (possibly summarized in a similar situation here: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=36298), which is why the leak summary does not show any memory that is definitely or indirectly lost.
>
> FWIW, the summary points to line 255 in the code, which is in the middle of an OMP pragma statement: https://github.com/grunwaldlab/poppr/blob/fda8606ab9c996542cabc8c9092e024ceb86e4cd/src/bitwise_distance.c#L254-L259
Kurt's response on 2016-06-13:

> Right. So there's perhaps nothing you can do about this.
>
> On its way to CRAN ...
>
> Best
> -k

## Downstream dependencies

Expand Down

0 comments on commit 5374669

Please sign in to comment.