This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Work in progress
…st/ringteki into card/tel/Total-Warfare
Also trying to get flipping and discarding of attachments to work.
…st/ringteki into card/tel/Total-Warfare
…st/ringteki into card/tel/Total-Warfare
add test for VoH double-attachment crash
Done as a test to see if this fixes the issue around turning dynasty characters into attachments (VotA)
* Cards in discard piles use printed type to determine location legality. * Fix: Allow provinces to check for and remove illegal attachments. Fix: when discarding cards, fallback to type if printedType doesn't exist. Minor test cleanup * Corrected log message. It not English so good.
marcsoiferman-cm
approved these changes
Nov 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3525