Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

TEL - Total Warfare #3630

Merged
merged 30 commits into from
Nov 19, 2019
Merged

TEL - Total Warfare #3630

merged 30 commits into from
Nov 19, 2019

Conversation

The-Outcast
Copy link
Collaborator

@The-Outcast The-Outcast commented Nov 2, 2019 •
edited
Loading

closes #3525

@coveralls
Copy link

coveralls commented Nov 7, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.03%) to 87.162% when pulling 7c25e91 on The-Outcast:card/tel/Total-Warfare into 1555aea on gryffon:tel.

@The-Outcast The-Outcast marked this pull request as ready for review November 7, 2019 10:21
The-Outcast and others added 10 commits November 7, 2019 20:54
@The-Outcast
Fix lint errors
f246b4c
@The-Outcast
Merge branch 'card/tel/Total-Warfare' of https://github.com/The-Outca…
0f3a49a 
…st/ringteki into card/tel/Total-Warfare
@The-Outcast
apply attachment limit and more tests
1014d8f
@The-Outcast
add trait limits to attachment conditions
a9bee5c
@Syrail
add test for VoH double-attachment crash
d24240e
@The-Outcast
Merge pull request #2 from Syrail/card/tel/Total-Warfare
8f94822 
add test for VoH double-attachment crash
@Syrail @The-Outcast
Added test to verify detachment of second attached Watch Commander (#4)
2c173af
@The-Outcast
Remove lasting effects in leavePlayEventHandler
724c891 
Done as a test to see if this fixes the issue around turning dynasty characters into attachments (VotA)
@Syrail @The-Outcast
Update game engine to check for illegal attachments on provinces (#5)
f9e5369 
* Cards in discard piles use printed type to determine location legality.

* Fix: Allow provinces to check for and remove illegal attachments.
Fix: when discarding cards, fallback to type if printedType doesn't exist.
Minor test cleanup

* Corrected log message. It not English so good.
@The-Outcast
Also render stronghold province attachments and don't reveal facedown…
d1b85db 
… name
@The-Outcast The-Outcast merged commit a54298a into gryffon:tel Nov 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeremylarner jeremylarner jeremylarner left review comments

@marcsoiferman-cm marcsoiferman-cm marcsoiferman-cm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@The-Outcast @coveralls @jeremylarner @marcsoiferman-cm @Syrail