Update game engine to check for illegal attachments on provinces #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Syrail
changed the title
Syrail
changed the title
Fix: when discarding cards, fallback to type if printedType doesn't exist. Minor test cleanup
Syrail
force-pushed
the
card/tel/Total-Warfare
branch
from
cfe5203
to
7580e47
Compare
Syrail
changed the title
The-Outcast
added a commit
that referenced
this pull request
Nov 20, 2019
* TEL - Kitsu Motso - Work in progress * Trying to get provinces passed as attachable cards. * Add attachment conditions * Total Warfare happy path * Total Warfare testing Also trying to get flipping and discarding of attachments to work. * Remove references to attachToProvinceAction * Don't discard attachments on flip * Fix tests and attaching to province * Go back to checking cardtype for province to attach to * Fix code style breaches * Fix lint errors * apply attachment limit and more tests * add trait limits to attachment conditions * add test for VoH double-attachment crash * Added test to verify detachment of second attached Watch Commander (#4) * Remove lasting effects in leavePlayEventHandler Done as a test to see if this fixes the issue around turning dynasty characters into attachments (VotA) * Update game engine to check for illegal attachments on provinces (#5) * Cards in discard piles use printed type to determine location legality. * Fix: Allow provinces to check for and remove illegal attachments. Fix: when discarding cards, fallback to type if printedType doesn't exist. Minor test cleanup * Corrected log message. It not English so good. * Also render stronghold province attachments and don't reveal facedown name * Rework traitlimit definition * - Move attachment functionality to Basecard * Fix linting errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.