-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes needed to XML/WithFullCombinationOfFields #335
Comments
@sboeckelmann , @dakbhavesh , @VladimirAlexiev ,
|
This is #276 issue4
Because Since EPCIS JSON doesn't carry MasterData, I think we should remove this prefix from the context. |
@VladimirAlexiev up to now, EPCIS 1.x ILMD fields carry |
I've seen
Yes, but it appeared in a few XML that had some example master data. |
@VladimirAlexiev those two examples (bestBeforeDate, lotNumber) are most common, in the DSCSA (Pharma) context. |
grep -c '"gs1:' */*.xml|grep -v :0
AssociationEvent/AssociationEventExamples.xml:1
Mimasu/Example-associatonEvent-sensor.xml:1
WithEventHashID/event_with_identical_hash_id_1.xml:1
WithEventHashID/event_with_identical_hash_id_2.xml:1
WithEventHashID/event_with_identical_hash_id_3.xml:1
WithEventHashID/event_with_identical_hash_id_4.xml:1
WithEventHashID/event_with_identical_hash_id_5.xml:1
WithEventHashID/event_with_identical_hash_id_6.xml:1
WithExtension/TransactionEvent.xml:1
WithExtension/TransformationEvent.xml:1
WithFullCombinationOfFields/aggregation_event_all_possible_fields.xml:1
WithFullCombinationOfFields/association_event_all_possible_fields.xml:1
WithFullCombinationOfFields/object_event_all_possible_fields.xml:1
WithFullCombinationOfFields/transaction_event_all_possible_fields.xml:1
WithFullCombinationOfFields/transformation_event_all_possible_fields.xml:1
WithSensorData/SensorDataExamples.xml:46
@CraigRe please reopen and let's vote the last two bullets today |
Decided in Sep 21 telco:
Discussion: whether to add to the
|
@CraigRe reflect above in CBV § 9.3.1, using : instead of #. |
@sboeckelmann @dakbhavesh
I converted
XML/WithFullCombinationOfFields
to JSON using your tool and then had to make the following fixes (you can see most of them in VladimirAlexiev/EPCIS@47ad328):"ext1": "http://ext.com/ext1/"
to have a trailing slash (same forext2, ext3
) since namespaces should end at a reasonable delimiterSimilarly in Example-TransactionEvent-2020_07_03y.xml:
xmlns:rail="urn:gs1:epcisapp:rail:"
to have a trailing colon.Please make them in the XML. Thanks!
(And quickly close this issue lest Craig slaps us :-)
The text was updated successfully, but these errors were encountered: