Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in Censys snapshot data #112

Closed
jsf9k opened this issue Feb 26, 2018 · 1 comment · Fixed by #113
Closed

Error in Censys snapshot data #112

jsf9k opened this issue Feb 26, 2018 · 1 comment · Fixed by #113

Comments

@jsf9k
Copy link
Contributor

jsf9k commented Feb 26, 2018

@dav3r noticed some odd domains appearing in this week's DHS NCATS HTTPS and trustymail reports. I tracked the problem down to these lines in censys-federal-snapshot.csv.

It's simple enough to create a PR with the offending lines removed, but I thought this may point to a deeper problem in the code that collects the snapshot.

@konklone
Copy link
Contributor

For quick reference in the thread, the lines are:

dns name=trainingprism-test.dhs.gov
dns name=trainingprism.dhs.gov

Hmm, I wonder if this specifically related to the BigQuery-driven collection process, or if this was also the case prior to using BigQuery.

Anyway, good eye - I filed 18F/domain-scan#200 in the source repo, since that's where the fix should come from. I'll also delete the two offending lines from the snapshot now so that they're removed for tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants