Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Chrome Custom Tabs #363

Closed
gsantner opened this issue Oct 2, 2018 · 3 comments
Closed

Add support for Chrome Custom Tabs #363

gsantner opened this issue Oct 2, 2018 · 3 comments

Comments

@gsantner
Copy link
Owner

gsantner commented Oct 2, 2018

General information

  • App version: v1.2.2
  • System: Android 7.0.1

Description

Currently Markor always does open an external browser when clicking on something that is not a filepath (in browser) or using the "open link" textaction.
It would be nice to use the "Chrome Custom Tabs" feature to show links, which allows to much faster view contents. Reference to docs (many guides and blogs posts available which shows howto too): https://developer.android.com/reference/android/support/customtabs/package-summary / https://developers.chrome.com/multidevice/android/customtabs

This is also already done in another project of mine, dandelion* where you can too find some hints. Important is that this does not only work with Chrome, but also Firefox/Fennec (which implements the interface too). Be sure to specify their package id's and that should work.

https://developers.chrome.com/multidevice/images/customtab/performance.gif

@lifeLessCoder
Copy link
Contributor

lifeLessCoder commented Oct 2, 2018

Hey can I start working on this? @gsantner

@gsantner
Copy link
Owner Author

gsantner commented Oct 3, 2018

Of course, no need to ask! :-)

@lifeLessCoder
Copy link
Contributor

@gsantner Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants