Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing case of the file name deletes the file #8

Closed
sjmduncan opened this issue Sep 17, 2017 · 3 comments
Closed

Changing case of the file name deletes the file #8

sjmduncan opened this issue Sep 17, 2017 · 3 comments

Comments

@sjmduncan
Copy link
Contributor

Version 0.1.1 (F-Droid)

Changing the case of one or more letters of the filename from within Markor will delete the file.

For example

Notes -> notes
Notes -> NoTes
Notes -> nOTES
...

Will delete Notes.md while

Notes -> Mynotes
Notes -> note
Notes -> Motes
...

Are safe renames.

@gsantner
Copy link
Owner

Hm. Maybe a bug/(feature) of java.io.File.rename() . thanks for reporting

gsantner added a commit that referenced this issue Sep 17, 2017
@gsantner
Copy link
Owner

@sjmduncan
What would you say fits best as icon for rename, out of https://material.io/icons/ ?

@sjmduncan
Copy link
Contributor Author

sjmduncan commented Sep 18, 2017

@gsantner I can't see a better one The 'mode edit' icon makes the most sense.

I do think the icons could be better. The new file icon could be 'note add' and the move icon could just be 'folder'. Rename and the editor shortcut in preview are probably fine sharing the 'mode edit' icon because they do the expected thing in their respective contexts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants