Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the forgetful preview (#10) and some improvements to note saving and updating #12

Merged
merged 2 commits into from
Sep 18, 2017

Conversation

sjmduncan
Copy link
Contributor

Fix for #10.
Fix #8 for the case where the renaming is done by changing the title in the editor view.
Tidy up and clarify the saveNote method.

@gsantner
Copy link
Owner

Thanks!
merigng.

@gsantner gsantner merged commit ddc4d51 into gsantner:master Sep 18, 2017
subkanthi pushed a commit to subkanthi/markor that referenced this pull request May 5, 2018
… saving and updating (gsantner#12) by @sjmduncan

* Update the note file object when it is saved

Fixes some issues with switching between the preview and the editor

* Use case-safe file renaming when renaming is done in the editor view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants