Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Summary Statistics Helper Function for ChoiceDataset Class #7

Closed
TianyuDu opened this issue Aug 17, 2022 · 4 comments
Closed

Summary Statistics Helper Function for ChoiceDataset Class #7

TianyuDu opened this issue Aug 17, 2022 · 4 comments
Assignees
@TianyuDu
Labels
enhancement New feature or request

Comments

@TianyuDu
Copy link
Collaborator

No description provided.

@TianyuDu TianyuDu self-assigned this Aug 17, 2022
@TianyuDu TianyuDu mentioned this issue Aug 17, 2022
Open
@TianyuDu
Copy link
Collaborator Author

I am currently working on this on the dataset-summary-method branch here.

@TianyuDu
Copy link
Collaborator Author

I have created a pull request here implementing the summary() feature.

Here is an example output from the summary() method:

image

@kanodiaayush Could you please review the pull request a bit and let me know if you have any comments? I will merge the branch after the weekend.

@TianyuDu TianyuDu added the enhancement New feature or request label Aug 27, 2022
@kanodiaayush
Copy link
Contributor

I like this. I imagine after some people (or we ourselves) use it a bit we will have feedback points on this. I am approving the pull request. I took a look at the code and it looks good to me.

Thanks for adding this. This is a good one.

@TianyuDu
Copy link
Collaborator Author

TianyuDu commented Sep 1, 2022

Merged.

@TianyuDu TianyuDu closed this as completed Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TianyuDu TianyuDu

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kanodiaayush @TianyuDu