Explicit injection annotations #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the factory pattern used in the library isn't supported by ngmin, minification (with enabled name mangling) breaks the dependency injection. This adds explicit annotations with the array syntax.
gsklee
pushed a commit
that referenced
this pull request
Jul 24, 2013
Add explicit injection annotations
|
Thanks @passy! Any idea why ngmin can't handle this? |
|
/ping @btford I'm not sure if this is something that ngmin could do. It looks rather complex to me to figure out just from the AST that the return value of |
|
I could either explicitly look for "function calls that return injectables that are invoked by one of the methods to create a provider for a module," but I'd rather not special-case this. In order to make |
|
You can track my progress here if you're interested: btford/ngmin#44 |
|
@btford Cool! |
egilkh
added a commit
that referenced
this pull request
May 13, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the factory pattern used in the library isn't supported by ngmin,
minification (with enabled name mangling) breaks the dependency injection. This
adds explicit annotations with the array syntax.