We leak

[frozencemetery]

On current rawhide, with valgrind and debuginfos installed, if we do make check CHECKARGS='--force-valgrind --valgrind-cmd valgrind\ --track-origins=yes\ --leak-check=full, two problems occur.

First, we leak a whole bunch:

[root@localhost testdir]# grep -ir 'definitely lost:' | grep -v '0 bytes in 0 blocks'
test_0.log:==38725==    definitely lost: 864 bytes in 5 blocks
test_24.log:==38758==    definitely lost: 1,198 bytes in 4 blocks
test_7.log:==38733==    definitely lost: 120 bytes in 3 blocks
test_22.log:==38756==    definitely lost: 1,199 bytes in 4 blocks
test_18.log:==38752==    definitely lost: 1,199 bytes in 4 blocks
test_1.log:==38727==    definitely lost: 1,199 bytes in 4 blocks
gssproxy.log:==38718==    definitely lost: 32,302 bytes in 28 blocks
test_10.log:==38736==    definitely lost: 184 bytes in 6 blocks
test_6.log:==38732==    definitely lost: 120 bytes in 3 blocks
test_14.log:==38748==    definitely lost: 1,200 bytes in 4 blocks
test_9.log:==38735==    definitely lost: 120 bytes in 3 blocks
test_5.log:==38731==    definitely lost: 120 bytes in 3 blocks
test_4.log:==38730==    definitely lost: 184 bytes in 6 blocks
test_12.log:==38746==    definitely lost: 1,166 bytes in 4 blocks
test_11.log:==38739==    definitely lost: 80 bytes in 2 blocks
test_11.log:==38740==    definitely lost: 80 bytes in 2 blocks
test_11.log:==38738==    definitely lost: 814 bytes in 2 blocks
test_8.log:==38734==    definitely lost: 184 bytes in 6 blocks
test_26.log:==38760==    definitely lost: 128 bytes in 4 blocks
[root@localhost testdir]# 

Second, not all the tests pass:

...
[PASS] (15) Accept test returned 0
Testing positive program name matching...
  Testing basic acquire creds...
[FAIL] (16) Acquire test returned 255 (expected zero)
[INFO] To debug this test case, run:
    make check CHECKARGS='--debug-num=16'
Testing negative program name matching...
  Testing basic acquire creds...
[PASS] (17) Acquire test returned 255
[FAIL] Program test returned 255 (expected zero)
Testing basic SIGHUP with no change
  Testing basic init/accept context
[PASS] (18) Init test returned 0
...

I've played with timeouts and there doesn't seem to be a value that gets them all passing. Unfortunately I don't have time to dig further into this right now.

[frozencemetery]

Presumably addressing this will also involve first handling #9.