-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Bindings to enable WebRTC #129
Create Bindings to enable WebRTC #129
Conversation
* @return the {@link Structure} set on the promise reply. | ||
*/ | ||
public Structure getReply() { | ||
return Structure.objectFor(GSTPROMISE_API.gst_promise_get_reply(this), false, false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return Structure.objectFor(GSTPROMISE_API.gst_promise_get_reply(this), false, false); | |
return Structure.objectFor(GSTPROMISE_API.ptr_gst_promise_get_reply(this), false, false); |
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@roysjosh please add a little more explanation on a code review than "Thanks!", thanks! 😄
Bug. ;) I've been using this PR (and the last) for a few weeks now. I see mixed success on getting the create-offer Promise callback to fire at all. Sometimes when it fires I get this shortly after:
Finally, sometimes after my app has been running for a while and has an active WebRTC session up I am getting:
Any tips on debugging these issues? I tried valgrind earlier but it doesn't seem to play well with java. |
@roysjosh please open an issue with minimal code required to reproduce this please and we can discuss there. You can use environment variables to set native GStreamer logging and/or step through in the Java debugger to see if there's a specific line point this problem. It's almost certainly an ownership issue somewhere. |
@roysjosh as @neilcsmith-net stated this is likely an ownership issue and I would like to see a code example showing the issue you see. I've been able to run WebRTC sessions for 30 minutes without issues (after which I just manually stopped it) so I'm interested in how you are doing things. As for debugging I've just enabled logging for |
@a-morales thanks! How feasible is a small PR for https://github.com/gstreamer-java/gst1-java-examples that covers usage of this code that matches up with how you're using it? Would like to pull this in to release very soon in 0.9.4 before I do some refactoring that might interface with the PR. |
@neilcsmith-net I've been pretty busy the past couple of weeks, but once I have some spare time I can create a PR in the examples repo. |
@a-morales no problem! I'm away at a conference this week anyway. My plan is to try and release |
@a-morales apologies for the noise - needed to close and reopen to trigger Travis. Now need to work out the best strategy for the test failing - needs to be optional on earlier versions of GStreamer. |
Thank you @a-morales and @vinicius-tona for working on this. Squashed and merged via #135 because of a couple of test issues I needed to fix. |
Rebase of #117