Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Bindings to enable WebRTC #135

Merged
merged 14 commits into from
Jan 25, 2019
Merged

Create Bindings to enable WebRTC #135

merged 14 commits into from
Jan 25, 2019

Conversation

neilcsmith-net
Copy link
Member

Possible replacement for #129 with test version changes.

@neilcsmith-net
Copy link
Member Author

@a-morales OK, as well as adding version checks into the tests, I had to remove a GTYPE field from WebRTCSessionDescriptor. Do you have a use for this? It's not used in the library itself. Having it as a static field causes the webrtc native library to be loaded during Gst.init() which will break all usage with GStreamer < 1.14.

@neilcsmith-net neilcsmith-net merged commit e45c0e2 into gstreamer-java:master Jan 25, 2019
@neilcsmith-net neilcsmith-net mentioned this pull request Jan 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neilcsmith-net @vinicius-tona