Validate appdata #251
Merged
Validate appdata #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hfiguiere
commented
Mar 26, 2024
hfiguiere
commented
- Update to the newer standard ( Install appdata files to /usr/share/metainfo #241)
- Set proper app id
- Add launchable
- Update to the newer standard (gtimelog#241) - Set proper app id - Add launchable Signed-off-by: Hubert Figuière <hub@figuiere.net>
|
Some of the patches I had to apply to rebuild on flathub. |
mgedmin
reviewed
Mar 26, 2024
| <application> | ||
| <id type="desktop">gtimelog.desktop</id> | ||
| <component type="desktop-application"> | ||
| <id>org.gtimelog.GTimeLog</id> |
There was a problem hiding this comment.
I noticed that appstreamcli validate --strict --explain --pedantic gtimelog.appdata.xml says
P: org.gtimelog.GTimeLog:3: cid-contains-uppercase-letter org.gtimelog.GTimeLog
The component ID should only contain lowercase characters.
There was a problem hiding this comment.
yeah there is a lot of stuff it will say that are IMHO irrelevant. This is one of them. The spec written by the same people say to not change the ID.
For a different reason I would say to NOT change the ID for that reason. And I think the app id pass to GApplication should also be synced with this.
There was a problem hiding this comment.
Also renaming the .desktop file and icons to match and have all of these installed by the makefile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.