Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate appdata #251

Merged
merged 1 commit into from Mar 26, 2024
Merged

Validate appdata #251

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
22 changes: 13 additions & 9 deletions gtimelog.appdata.xml
View file
Open in desktop
@@ -1,29 +1,33 @@
<?xml version="1.0" encoding="UTF-8"?>
<application>
<id type="desktop">gtimelog.desktop</id>
<component type="desktop-application">
<id>org.gtimelog.GTimeLog</id>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that appstreamcli validate --strict --explain --pedantic gtimelog.appdata.xml says

P: org.gtimelog.GTimeLog:3: cid-contains-uppercase-letter org.gtimelog.GTimeLog
   The component ID should only contain lowercase characters.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah there is a lot of stuff it will say that are IMHO irrelevant. This is one of them. The spec written by the same people say to not change the ID.

For a different reason I would say to NOT change the ID for that reason. And I think the app id pass to GApplication should also be synced with this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also renaming the .desktop file and icons to match and have all of these installed by the makefile.

<metadata_license>CC0-1.0</metadata_license>
<project_license>GPL-2.0</project_license>

<name>Time Log</name>
<summary>Unobtrusively keep track of your time</summary>
<description>
<p>GTimeLog is a small GNOME app for keeping track of your time. Its main goal is to be as unobtrusive as possible.</p>
</description>
<screenshots>
<screenshot type="default">https://gtimelog.org/gtimelog.png</screenshot>
<screenshot type="default">
<image>https://gtimelog.org/gtimelog.png</image>
</screenshot>
</screenshots>
<developer_name>Time Log developers</developer_name>
<keywords>
<keyword>time</keyword>
<keyword>tracking</keyword>
<keyword>logging</keyword>
</keywords>
<launchable type="desktop-id">gtimelog.desktop</launchable>
<url type="homepage">https://gtimelog.org/</url>
<updatecontact>marius@gedmin.as</updatecontact>
<component>
<translation type="gettext">gtimelog</translation>
</component>
<update_contact>marius@gedmin.as</update_contact>
<translation type="gettext">gtimelog</translation>
<content_rating type="oars-1.1" />
<releases>
<release version="0.11.3" date="2019-04-23" />
</releases>
</application>
<provides>
<id>gtimelog.desktop</id>
</provides>
</component>