Enums #115
Enums #115
Conversation
|
@gkoz Please, look at changed functions with |
| pub fn get_key(&self, index_: u32, keyval: &mut u32) -> (bool,::ModifierType) { | ||
| unsafe { | ||
| let mut modifiers = mem::uninitialized(); | ||
| let ret = from_glib(ffi::gdk_device_get_key(self.to_glib_none().0, index_, keyval, &mut modifiers)); |
There was a problem hiding this comment.
This looks like a typical case of out-params + boolean, returning Option<(u32, ModifierType)>.
|
We'll also want This part seems easy and harmless enough. Are the remaining reexports in |
| library = "Gdk" | ||
| version = "3.0" | ||
| min_cfg_version = "3.4" | ||
| target_path = "." | ||
| work_mode = "normal" | ||
| generate_safety_asserts = true | ||
| #generate_safety_asserts = true |
There was a problem hiding this comment.
We have the same set of asserts here as in gtk.
|
Fixed, also updated |
| @@ -1,12 +1,21 @@ | |||
| [options] | |||
| girs_dir = "gir-files" | |||
| girs_dir = "../gir-files" | |||
There was a problem hiding this comment.
Since we're generating some code now it makes sense to add the usual submodules and makefile.
|
Added submodules. |
|
I strongly don't like idea of having many |
|
Updated makefile |
|
Ready for merge, all errors on gtk part |
|
Good for me. @gkoz: Merge if you think it's all good. |
|
Added |
|
This PR is getting bigger and bigger. O.O |
|
Yes, it too many unneeded additions |
Part of gtk-rs/gtk#307