New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enums #115

Merged
merged 3 commits into from Apr 20, 2016

Conversation

Projects
None yet
3 participants
@EPashkin
Member

EPashkin commented Apr 18, 2016

Part of gtk-rs/gtk#307

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Apr 18, 2016

Member

@gkoz Please, look at changed functions with uninitialized
IMHO PR ready for merge.

Member

EPashkin commented Apr 18, 2016

@gkoz Please, look at changed functions with uninitialized
IMHO PR ready for merge.

Show outdated Hide outdated src/device.rs Outdated
@gkoz

This comment has been minimized.

Show comment
Hide comment
@gkoz

gkoz Apr 18, 2016

Member

We'll also want Gdk.GLError.

This part seems easy and harmless enough. Are the remaining reexports in lib.rs apparently unused? There seem to be too many of them.

Member

gkoz commented Apr 18, 2016

We'll also want Gdk.GLError.

This part seems easy and harmless enough. Are the remaining reexports in lib.rs apparently unused? There seem to be too many of them.

Show outdated Hide outdated Gir.toml Outdated
@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Apr 19, 2016

Member

Fixed, also updated gdk_window_get_device_position and gdk_window_get_device_position_double as seems returning Window and returning other independent (https://developer.gnome.org/gdk3/stable/gdk3-Windows.html#gdk-window-get-device-position)

Member

EPashkin commented Apr 19, 2016

Fixed, also updated gdk_window_get_device_position and gdk_window_get_device_position_double as seems returning Window and returning other independent (https://developer.gnome.org/gdk3/stable/gdk3-Windows.html#gdk-window-get-device-position)

Show outdated Hide outdated Gir.toml Outdated
ffi::gdk_window_get_device_position_double(self.to_glib_none().0,
device.to_glib_none().0,
&mut x, &mut y, &mut mask));
(ret, x, y, from_glib(mask))

This comment has been minimized.

@gkoz

gkoz Apr 19, 2016

Member

Yep, this seems to be more correct than before. I wonder if the generator would do the same...

@gkoz

gkoz Apr 19, 2016

Member

Yep, this seems to be more correct than before. I wonder if the generator would do the same...

This comment has been minimized.

@EPashkin

EPashkin Apr 19, 2016

Member

Its copy-pasted from generated code ;)

@EPashkin

EPashkin Apr 19, 2016

Member

Its copy-pasted from generated code ;)

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Apr 19, 2016

Member

Added submodules.

Member

EPashkin commented Apr 19, 2016

Added submodules.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Apr 19, 2016

Member

I strongly don't like idea of having many gir sub-modules ,
as it slow to rebuild and contains "big" target,
so IMHO we need rethink sub-module structure.

Member

EPashkin commented Apr 19, 2016

I strongly don't like idea of having many gir sub-modules ,
as it slow to rebuild and contains "big" target,
so IMHO we need rethink sub-module structure.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Apr 19, 2016

Member

Updated makefile

Member

EPashkin commented Apr 19, 2016

Updated makefile

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Apr 19, 2016

Member

Ready for merge, all errors on gtk part

Member

EPashkin commented Apr 19, 2016

Ready for merge, all errors on gtk part

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Apr 20, 2016

Member

Good for me.

@gkoz: Merge if you think it's all good.

Member

GuillaumeGomez commented Apr 20, 2016

Good for me.

@gkoz: Merge if you think it's all good.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Apr 20, 2016

Member

Added CursorType

Member

EPashkin commented Apr 20, 2016

Added CursorType

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Apr 20, 2016

Member

This PR is getting bigger and bigger. O.O

Member

GuillaumeGomez commented Apr 20, 2016

This PR is getting bigger and bigger. O.O

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Apr 20, 2016

Member

Yes, it too many unneeded additions

Member

EPashkin commented Apr 20, 2016

Yes, it too many unneeded additions

@gkoz gkoz merged commit 95e4e16 into gtk-rs:master Apr 20, 2016

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details

@EPashkin EPashkin deleted the EPashkin:enums branch Apr 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment