Skip to content
This repository has been archived by the owner on Jun 8, 2021. It is now read-only.

Add missing impls for Atom #148

Merged
merged 1 commit into from
Mar 28, 2017
Merged

Add missing impls for Atom #148

merged 1 commit into from
Mar 28, 2017

Conversation

Susurrus
Copy link
Contributor

Fixes necessary for gtk-rs/gtk#478

@EPashkin
Copy link
Member

👍 without it function returning Atom not work

@Susurrus
Copy link
Contributor Author

As part of this Atom work we're also missing all of the Atoms specified on the Selections page. I don't even see them in gdk-sys though, so should I file a separate issue on the sys repo or how should I go about adding these?

@EPashkin
Copy link
Member

May be it can be done as https://github.com/gtk-rs/gdk/blob/master/src/atom.rs#L11 but it need checked.
Also we don't have any of selection functions, so maybe these const need go to separate manual/selection.rs with adding some functions.
Also seems these selection functions X11 related and need be hidden under #[cfg(target_os = "linux")] but may be not, currently I don't ready fo check it.
Maybe @GuillaumeGomez know more about it?
I not against add constants somewhere if its really needed, but not sure if it need be added in this PR as it stall other PRs.

@Susurrus
Copy link
Contributor Author

Right now the only thing that would be nice would be the constants. I'll add those as a separate issue and we can keep this PR focused on just this small part!

@GuillaumeGomez
Copy link
Member

@EPashkin: If it's X11 specific, then we need to make conditional compilation for it like we did in some other parts as well.

@EPashkin
Copy link
Member

@GuillaumeGomez X11 specific part moved to separate issue #149 (if it really specific)

@GuillaumeGomez
Copy link
Member

Ah my bad. Then it's all good for me as well. Thanks @Susurrus!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants