More functions that probably shouldn't return an Option

[sophie-h]

• gio::File::get_uri() https://gitlab.gnome.org/GNOME/glib/blob/master/gio/gfile.c#L639
• gio::File::get_uri_scheme() https://gitlab.gnome.org/GNOME/glib/blob/master/gio/gfile.c#L449

and

#define G_IS_FILE(obj)	       (G_TYPE_CHECK_INSTANCE_TYPE ((obj), G_TYPE_FILE))

If I am correct, there are probably many more functions, that shouldn't return an Option.

[EPashkin]

By https://gitlab.gnome.org/GNOME/glib/blob/master/gio/gfile.c#L6835 get_uri_scheme can return NULL in some cases.
At minimum get_uri implementation return NULL for nonabsolute paths
https://gitlab.gnome.org/GNOME/glib/blob/master/gio/glocalfile.c#L277
https://gitlab.gnome.org/GNOME/glib/blob/master/glib/gconvert.c#L1774

[sophie-h]

I think GFile has no concept/representation of relative paths. Relative arguments to g_file_new_for_path() lead to an absolute representation in g_file_get_uri(). Also, NULL is not documented as return value.

[EPashkin]

You right, for relative paths GLocalFile doing canonicalize.
I found only one call in gio, that checks it result for NULL: https://gitlab.gnome.org/GNOME/glib/blob/master/gio/win32/gwinhttpfile.c#L243,
so maybe you right about get_uri

[sdroege]

So anything that has to be done here?

[sophie-h]

@sdroege it's probably more the question where to start? There is a lot of functions that don't need to return an Option. I don't know if it is really efficient if I am opening an issue for every singe function (#158, gtk-rs/gtk#709).

[sdroege]

Well, it needs someone to systematically go over all these functions and check what would be correct, and then make a PR with the changes :) If you don't plan to do that, just doing an issue for every (group of) functions you find that look wrong is fine too.

The functions mentioned here seem to be correct though? Unlikely that they return None but unfortunately that can

[sdroege]

Let's close this then. Please open new issues for everything you notice that shouldn't return an Option :)

[sophie-h]

The functions mentioned here seem to be correct though? Unlikely that they return None but unfortunately that can

I don't think so.

[sdroege]

Checked again and you're right that these functions shouldn't return an Option. The discussion above confused me! Will fix :)

[sdroege]

See #221