Skip to content
This repository has been archived by the owner on Jun 8, 2021. It is now read-only.

New types v2 #122

Merged
merged 2 commits into from
Jun 12, 2018
Merged

New types v2 #122

merged 2 commits into from
Jun 12, 2018

Conversation

GuillaumeGomez
Copy link
Member

@EPashkin
Copy link
Member

@GuillaumeGomez Seems you forgot add Gir.toml changes

@sdroege
Copy link
Member

sdroege commented Jun 11, 2018

generally seems fine but I don't have the time to go through each function in detail now. Did you check that each Option return value can actually be NULL?

@GuillaumeGomez
Copy link
Member Author

No, I'll.

@GuillaumeGomez GuillaumeGomez force-pushed the new-types-v2 branch 2 times, most recently from b9ee445 to 274a0a3 Compare June 11, 2018 19:18
@GuillaumeGomez
Copy link
Member Author

Ok, should be ready now.

use std::ptr;

glib_wrapper! {
pub struct FileIOStream(Object<ffi::GFileIOStream, ffi::GFileIOStreamClass>): IOStream, Seekable;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange, this file not generated now :(

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was quite surprised as well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, forgot that it was file_io_stream.rs now

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GuillaumeGomez, Please do clean regen.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I did? I updated gir and ran make gir. Is there something else to do?

Copy link
Member

@EPashkin EPashkin Jun 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make gir don't clean auto folder, only make regen_check doing it

@GuillaumeGomez
Copy link
Member Author

Removed extra files as well!

@EPashkin
Copy link
Member

Thanks, now we can eject CD ;)
👍 but better wait until https://travis-ci.org/gtk-rs/gio/jobs/390942790 passed.

@GuillaumeGomez
Copy link
Member Author

Haha, true!

I wait for CIs in any case.

@GuillaumeGomez GuillaumeGomez merged commit d0aa122 into gtk-rs:master Jun 12, 2018
@GuillaumeGomez GuillaumeGomez deleted the new-types-v2 branch June 12, 2018 11:01
vhdirk pushed a commit to vhdirk/gio-rs that referenced this pull request Jan 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants