New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New types v2 #122

Merged
merged 2 commits into from Jun 12, 2018

Conversation

Projects
None yet
3 participants
@GuillaumeGomez
Member

GuillaumeGomez commented Jun 10, 2018

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Jun 11, 2018

Member

@GuillaumeGomez Seems you forgot add Gir.toml changes

Member

EPashkin commented Jun 11, 2018

@GuillaumeGomez Seems you forgot add Gir.toml changes

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Jun 11, 2018

Member

generally seems fine but I don't have the time to go through each function in detail now. Did you check that each Option return value can actually be NULL?

Member

sdroege commented Jun 11, 2018

generally seems fine but I don't have the time to go through each function in detail now. Did you check that each Option return value can actually be NULL?

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Jun 11, 2018

Member

No, I'll.

Member

GuillaumeGomez commented Jun 11, 2018

No, I'll.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Jun 11, 2018

Member

Ok, should be ready now.

Member

GuillaumeGomez commented Jun 11, 2018

Ok, should be ready now.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Jun 11, 2018

Member

Removed extra files as well!

Member

GuillaumeGomez commented Jun 11, 2018

Removed extra files as well!

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Jun 11, 2018

Member

Thanks, now we can eject CD ;)
👍 but better wait until https://travis-ci.org/gtk-rs/gio/jobs/390942790 passed.

Member

EPashkin commented Jun 11, 2018

Thanks, now we can eject CD ;)
👍 but better wait until https://travis-ci.org/gtk-rs/gio/jobs/390942790 passed.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Jun 11, 2018

Member

Haha, true!

I wait for CIs in any case.

Member

GuillaumeGomez commented Jun 11, 2018

Haha, true!

I wait for CIs in any case.

@GuillaumeGomez GuillaumeGomez merged commit d0aa122 into gtk-rs:master Jun 12, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@GuillaumeGomez GuillaumeGomez deleted the GuillaumeGomez:new-types-v2 branch Jun 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment