Skip to content
This repository has been archived by the owner on Jun 8, 2021. It is now read-only.

Add impls for new std::io::{Read,Write} structs #172

Merged
merged 3 commits into from
Dec 3, 2018
Merged

Add impls for new std::io::{Read,Write} structs #172

merged 3 commits into from
Dec 3, 2018

Conversation

fkrull
Copy link
Contributor

@fkrull fkrull commented Nov 20, 2018

I added impls for Debug, PartialEq, Eq, Hash, Clone to the new helper structs.

@sdroege There already are into_input_stream and into_output_stream methods on the structs to turn them back into the gio types. Or did you mean something else?

@sdroege
Copy link
Member

sdroege commented Nov 28, 2018

@sdroege There already are into_input_stream and into_output_stream methods on the structs to turn them back into the gio types. Or did you mean something else?

@fkrull I was thinking of Deref, or a function to get the stream reference from it (without consuming the adapter). Do you think that would be useful?

Apart from that the PR here looks good. Sorry for not replying earlier!

@fkrull
Copy link
Contributor Author

fkrull commented Dec 2, 2018

I added some methods to get references to the wrapped streams. I decided against using Deref though since it seems semantically incorrect.

@sdroege
Copy link
Member

sdroege commented Dec 3, 2018

Looks good to me. @GuillaumeGomez ?

@GuillaumeGomez
Copy link
Member

Looks good to me as well. Thanks!

@GuillaumeGomez GuillaumeGomez merged commit 79e31ba into gtk-rs:master Dec 3, 2018
@fkrull fkrull deleted the extra-impls branch December 3, 2018 22:29
vhdirk pushed a commit to vhdirk/gio-rs that referenced this pull request Jan 16, 2019
Add impls for new std::io::{Read,Write} structs
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants