Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add impls for new std::io::{Read,Write} structs #172

Merged
merged 3 commits into from Dec 3, 2018

Conversation

Projects
None yet
3 participants
@fkrull
Copy link
Contributor

fkrull commented Nov 20, 2018

I added impls for Debug, PartialEq, Eq, Hash, Clone to the new helper structs.

@sdroege There already are into_input_stream and into_output_stream methods on the structs to turn them back into the gio types. Or did you mean something else?

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Nov 28, 2018

@sdroege There already are into_input_stream and into_output_stream methods on the structs to turn them back into the gio types. Or did you mean something else?

@fkrull I was thinking of Deref, or a function to get the stream reference from it (without consuming the adapter). Do you think that would be useful?

Apart from that the PR here looks good. Sorry for not replying earlier!

@fkrull

This comment has been minimized.

Copy link
Contributor Author

fkrull commented Dec 2, 2018

I added some methods to get references to the wrapped streams. I decided against using Deref though since it seems semantically incorrect.

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Dec 3, 2018

Looks good to me. @GuillaumeGomez ?

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Dec 3, 2018

Looks good to me as well. Thanks!

@GuillaumeGomez GuillaumeGomez merged commit 79e31ba into gtk-rs:master Dec 3, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@fkrull fkrull deleted the fkrull:extra-impls branch Dec 3, 2018

vhdirk pushed a commit to vhdirk/gio-rs that referenced this pull request Jan 16, 2019

Merge pull request gtk-rs#172 from fkrull/extra-impls
Add impls for new std::io::{Read,Write} structs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.