-
-
Notifications
You must be signed in to change notification settings - Fork 31
Implement open signal and open function #34
Conversation
src/application.rs
Outdated
|
||
pub trait ApplicationExtManual { | ||
fn connect_open<F: Fn(&Self, &[File], &str) + 'static>(&self, f: F) -> u64; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remote this empty line.
src/application.rs
Outdated
} | ||
|
||
impl<O: IsA<Application> + IsA<glib::object::Object>> ApplicationExtManual for O { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remote this empty line.
src/application.rs
Outdated
transmute(open_trampoline::<Self> as usize), Box_::into_raw(f) as *mut _) | ||
} | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remote this empty line.
Thanks, @daa84 |
Patch updated, |
My most worry is |
hm, yes, your right, this looks like error, i'll check |
Not necessarily an error. Just preparing an array of references IMHO can be easier. |
Ok, i check open method in application and it works without problem, also i check code for to_glib_none() in case of array it creates new temp array with call to_glib_none for every member so it looks like it must work 😄 |
👍 |
Implement open signal and open function for #31