-
-
Notifications
You must be signed in to change notification settings - Fork 31
Async callbacks #85
Async callbacks #85
Conversation
Hm, should have run the tests :) I'm not sure what to do here, is there a way to specify a "transform" type for parameters (Here transform int to glib::Priority)? That doesn't seem likely, otherwise I can revert to manually written bindings for these four functions I suppose |
Those have to be manual unfortunately, unless you want to handle that somehow in gir too :) |
Not sure how I would do that tbh, gir doesn't know about glib::Priority, and the function expects an int, guess I'll just have to revert (would have been nice if these constants were actually an enum) |
Don't worry about tests, I hope adding PR today that fix it |
You could specially handle arguments in async functions that are called io_priority and are of type int. Ugly hack :) |
@EPashkin , curious how you will address this specific issue though ? |
Ah I see, with a dirty hack, worksforme :) I'll regen once this is merged then! |
@MathieuDuponchelle Gir updated. Don't forget update submodule 😉 |
775ab7a
to
c320369
Compare
@MathieuDuponchelle Thanks, but you forgot update gir submodule. (Something like |
As
|
c320369
to
55df621
Compare
Let's do that separately no? |
55df621
to
9a2be6b
Compare
I do not insist |
Should we get that in then? :) |
@MathieuDuponchelle LGFM, Thanks |
Let's go! (and thanks 😉) |
Is one of you going to do it? Otherwise please someone open a ticket so we don't forget :) |
Async callbacks
Split in two commits, one regenerating, the other removing manual implementations of many async functions.