Fix incorrect GIR due to gobject-introspection GitLab issue #189 #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes gtk-rs/sys#92. This is an alternate way of fixing it. My first attempt is the PR at gtk-rs/sys#93 where I added these functions as manual implementations.
This fixes the same issue, but by using fix.sh instead.
You can read about why the GIR is incorrect in gobject-introspection GitLab issue #189. Basically any header files that uses the
[]operator will have incorrect GIR generated from it.I took care to make sure to match the
const-ness of the functions in C.