analysis/properties: Remove unused ToValue import for property getters #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following [1] an unnecessary `glib::ToValue` import showed up in auto code, which does not appear to be used in gtk-rs nor gstreamer-rs. After all, getters convert from Values, not to Values. Fixes: c6cacb0 ("Implement handling of new Value traits") [1]: https://gitlab.freedesktop.org/gstreamer/gstreamer-rs/-/merge_requests/746#note_893561
sdroege
approved these changes
Apr 27, 2021
gstreamer-github
pushed a commit
to sdroege/gstreamer-rs
that referenced
this pull request
Apr 27, 2021
This was temporarily allowed by Value trait refactoring, but the root cause of the unused imports has been found (`glib::ToValue` for property getters) and fixed in gtk-rs/gir#1117.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following 1 an unnecessary
glib::ToValueimport showed up in autocode, which does not appear to be used in gtk-rs nor gstreamer-rs.
After all, getters convert from Values, not to Values.
Fixes: c6cacb0 ("Implement handling of new Value traits")
Cc @sdroege, this seems correct. Unfortunately
gtk-rswas already riddled with#[allow(unused_imports)].