codegen: use C value instead of hardcoding it #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
approved these changes
May 23, 2021
There was a problem hiding this comment.
Nice find! The FFI layer should be in control of the constants, not the safe wrapper layer 😬
Do change the title of the PR/commit to codegen/enum: Use FFI constant instead of (hardcoding) integer value though; I had no idea what this PR was about until reading the code ;)
sdroege
approved these changes
May 23, 2021
|
MUCH better! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See gtk-rs/gtk4-rs#397 for the resulted changes
cc @GuillaumeGomez, i suppose that's why we had such code in gtk's ResponseType, basically based on what gir generates :)