Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove leading '>' from tutorial #1365

Merged
merged 1 commit into from
Jun 13, 2022
Merged

Conversation

gwutz
Copy link
Contributor

@gwutz gwutz commented Jun 13, 2022

This change removes all leading '>' characters of console commands in order to be able to copy them from the tutorial.

This change removes all leading '>' characters of console commands in order to be able to copy them from the tutorial.
@MarijnS95
Copy link
Contributor

This was done to make markdown render console blocks directly, but it seems the markdown renderer used here (just like GitHub 's) wasn't fixed to prevent the > from being selected.

If you're serious about doing this, at the very least demote the type to sh or bash, as console now becomes entirely meaningless and broken.

@GuillaumeGomez GuillaumeGomez merged commit edee390 into gtk-rs:master Jun 13, 2022
MarijnS95 added a commit to MarijnS95/gir that referenced this pull request Jun 13, 2022
…ncerns consistently

[gtk-rs#1365] was blatantly merged without considering review, breaking syntax
highlighting on these codeblocks in the process.  As suggested, when
removing the "effective UID" prefix `console` codeblocks loose their
formatting and must instead be converted to regular `sh` or `bash`
types.

At the same time, make this change consistently across the book, instead
of considering `sys_library.md` to be the only page.  Note that it has
been retained in places where a `console` block is intented, because the
lines after a console command represent program output and are formatted
accordingly when no "effective UID" prefix is detected.

[gtk-rs#1365]: gtk-rs#1365
MarijnS95 added a commit to MarijnS95/gir that referenced this pull request Jun 13, 2022
…ncerns consistently

[gtk-rs#1365] was blatantly merged without considering review, breaking syntax
highlighting on these codeblocks in the process.  As suggested, when
removing the "effective UID" prefix `console` codeblocks loose their
formatting and must instead be converted to regular `sh` or `bash`
types.

At the same time, make this change consistently across the book, instead
of considering `sys_library.md` to be the only page.  Note that it has
been retained in places where a `console` block is intented, because the
lines after a console command represent program output and are formatted
accordingly when no "effective UID" prefix is detected.

[gtk-rs#1365]: gtk-rs#1365
bilelmoussaoui pushed a commit that referenced this pull request Oct 18, 2022
…ncerns consistently

[#1365] was blatantly merged without considering review, breaking syntax
highlighting on these codeblocks in the process.  As suggested, when
removing the "effective UID" prefix `console` codeblocks loose their
formatting and must instead be converted to regular `sh` or `bash`
types.

At the same time, make this change consistently across the book, instead
of considering `sys_library.md` to be the only page.  Note that it has
been retained in places where a `console` block is intented, because the
lines after a console command represent program output and are formatted
accordingly when no "effective UID" prefix is detected.

[#1365]: #1365
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants