This repository has been archived by the owner on Jun 8, 2021. It is now read-only.
Add Char wrapper; implement KeyFile::set_list_separator() with it #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We will use this to actually bind KeyFile::set_list_separator(), and as a general tool to pass values to C functions which expect a C 'char'.
sdroege
reviewed
Nov 12, 2017
| /// } | ||
| /// ``` | ||
| /// | ||
| /// This would be inconvenient because users would have to do the conversion from a Rust `char` to an `i8` by hand. It would be the same case for `libc::c_char`, which is just a type alias |
There was a problem hiding this comment.
They could pass b'a' for example
EPashkin
reviewed
Nov 12, 2017
Gir.toml
Outdated
| @@ -252,6 +252,10 @@ status = "generate" | |||
| # file parameter needs to be a PathBuf | |||
| ignore = true | |||
| [[object.function]] | |||
| name = "set_list_separator" | |||
| # separator parameter neds to be a glib::Char | |||
federicomenaquintero
force-pushed
the
char-wrapper
branch
from
6ed0260
to
e41d389
Compare
|
Better do regen with same |
|
@federicomenaquintero I'm very sorry for long delay. |
|
@GuillaumeGomez, seems @federicomenaquintero don't have time, maybe we just merge PR as is and then I make PR that add |
|
Sure, let's do it like that then. Thanks everyone! |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm in the process of adding "impl ToGlib" for all the fundamental types, so that gnome-class will have an easier time passing them around: then it can just call .to_glib() on every method argument with a fundamental type.
Along the way I ran into the distinction between Rust's
charand Glib's Cc_char. Here we introduce aCharwrapper, which can be created fallibly from a Rustchar. When it succeeds, the result can be passed to C functions that take ac_char.Finally, we implement
KeyFile::set_list_separatorin terms of this.