Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dyn and import warnings #491

Merged
merged 1 commit into from Jun 6, 2019

Conversation

Projects
None yet
3 participants
@GuillaumeGomez
Copy link
Member

commented Jun 5, 2019

@EPashkin

This comment has been minimized.

Copy link
Member

commented Jun 5, 2019

Thanks and 👍
Note: cairo also have one warning

warning: trait objects without an explicit `dyn` are deprecated
  --> D:/eap/rust/0/cairo\src\error.rs:73:32
   |
73 |     fn cause(&self) -> Option<&Error> {
   |                                ^^^^^ help: use `dyn`: `dyn Error`
@sdroege

This comment has been minimized.

Copy link
Member

commented Jun 5, 2019

👍

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

commented Jun 5, 2019

@EPashkin One crate at a time! Currently facing gio. :)

@sdroege sdroege merged commit 34b8df4 into gtk-rs:master Jun 6, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@GuillaumeGomez GuillaumeGomez deleted the GuillaumeGomez:warnings branch Jun 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.