Add print in case an upgrade failed

[GuillaumeGomez]

Just one question: should we put it behind a feature instead?

cc @sdroege @EPashkin

[EPashkin]

if cfg!(debug_assertions) ?

[EPashkin]

same as in https://doc.rust-lang.org/std/macro.debug_assert.html

[sdroege]

I don't agree with this change. Upgrade failing is not an error but often wanted behavior. -- Sent from my Android device with K-9 Mail. Please excuse my brevity.

[GuillaumeGomez]

No, it's definitely not. Take a look at gtk-rs/examples#294.

[GuillaumeGomez]

I'm not too certain using cfg(debug_assertions) is a great idea though... Having a debug feature or something along the line might be better I think.

Also, I'll need to add documentation about this as well.

[sdroege]

On February 16, 2020 6:00:46 PM GMT+01:00, Guillaume Gomez ***@***.***> wrote: No, it's definitely not. Take a look at gtk-rs/examples#294.

Yes that's a bug in the usage there. I don't want random noise to be printed in correct usage. That the value can disappear safely is the main feature of weak references and not an error.

…

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

[GuillaumeGomez]

That's why I want to put it behind a macro. In case you didn't use it correctly and you need more information to debug.

[sdroege]

As a separate debugging feature would be acceptable for me.

[GuillaumeGomez]

Then I'll do that instead.

[EPashkin]

@GuillaumeGomez note that current version don't build

error: variable 'variable' is still repeating at this depth
   --> src\clone.rs:136:65
    |
136 |                     println!("Failed to upgrade {}", stringify!($variable));
    |       

[GuillaumeGomez]

Ah? Strange, it worked fine for me...

[GuillaumeGomez]

Fixed the formatting...

[GuillaumeGomez]

Updated the domain as well.

[sdroege]

Otherwise good to be merged for me.

[sdroege]

👍