This repository has been archived by the owner on Jun 8, 2021. It is now read-only.
Allow container types in Variant #650
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently Variant API is limited to StaticVariantType, that can only be implemented by types with static+fixed signatures. This will not work for generic container types, where the signature is dependent on the child type. This patch adds a new trait that allows the type signature to be created dynamically. Blanket implementation is provided for common container types in Rust.
This will allow for container types to be used with the Variant API. Since all StaticVariantType are also DynamicVariantType, this change is not an API break.
sdroege
reviewed
Jun 5, 2020
sdroege
reviewed
Jun 5, 2020
Not breaking API is not a goal by itself :) If the API becomes weird otherwise let's rather break API. Here it seems like replacing the existing trait with something more generic would lead to better and less confusing API. |
|
Closing this in favour of #651 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows generic container types to be used with
VariantAPI w/o breaking the API.