glib: Optimize IntoGStr impl for String by simply appending a NUL-byte
#1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdroege
requested review from
pbor,
GuillaumeGomez,
bilelmoussaoui and
jf2048
sdroege
referenced
this pull request
in Lyude/neovim-gtk
Feb 20, 2023
`String` implements `IntoGStr`. So the dereference is not necessary
here.
```
warning: the borrowed expression implements the required traits
--> src/shell_dlg.rs:77:9
|
77 | &format!("Save changes to '{changed_files}'?"),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("Save changes to '{changed_files}'?")`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
warning: `nvim-gtk` (bin "nvim-gtk") generated 1 warning (run `cargo clippy --fix --bin "nvim-gtk"` to apply 1 suggestion)
```
sdroege
added
the
needs-backport
GuillaumeGomez
approved these changes
Feb 20, 2023
|
Thanks! |
pbor
added
backported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.