Add a std_once_cell feature #1113
Conversation
|
We lose the CI testing on the minimum supported version, rust 1.65. Are we sure we are ok with that? |
|
Why is the last test failing? |
|
The docs regen thing is unrelated to this |
.github/workflows/CI.yml
Outdated
| @@ -18,7 +18,7 @@ jobs: | |||
| - stable | |||
| - beta | |||
| - nightly | |||
| - "1.65.0" | |||
| - "1.70.0" | |||
There was a problem hiding this comment.
We lose the CI testing on the minimum supported version, rust 1.65. Are we sure we are ok with that?
No, this needs to be optional and the CI needs to be updated accordingly.
There was a problem hiding this comment.
CI needs to be updated accordingly.
What do toy mean by this?
There was a problem hiding this comment.
I removed in in the meantime from ci.
There was a problem hiding this comment.
You need to disable this specific feature for the 1.65 CI run. It would be good to enable it for the others though.
A6GibKm
force-pushed
the
rust-1.70
branch
2 times, most recently
from
275cd28
to
e7a0ab3
Compare
.github/workflows/CI.yml
Outdated
| @@ -23,7 +23,7 @@ jobs: | |||
| - { name: "cairo", features: "png,pdf,svg,ps,use_glib,v1_18,freetype,script,xcb,xlib,win32-surface", nightly: "--features 'png,pdf,svg,ps,use_glib,v1_18,freetype,script,xcb,xlib,win32-surface'", test_sys: true } | |||
| - { name: "gdk-pixbuf", features: "v2_42", nightly: "--all-features", test_sys: true } | |||
| - { name: "gio", features: "v2_74", nightly: "--all-features", test_sys: true } | |||
| - { name: "glib", features: "v2_74", nightly: "--all-features", test_sys: true } | |||
| - { name: "glib", features: "v2_74", nightly: "--features=v2_76,log,log_macros,compiletests", test_sys: true } | |||
There was a problem hiding this comment.
Well for nightly it's obviously fine to enable that feature. The way how it was before seemed good to me :) Sorry
I only didn't merge this yet because there was some CI failure and I had no time to look into that yet
That adds std::cell::OnceCell and std::sync::OnceLock support for the properties macro.
That adds std::cell::OnceCell and std::sync::OnceLock support for the properties macro.