glib: ignore various unneeded functions #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
previously approved these changes
Dec 11, 2021
|
There are also various functions in |
sdroege
reviewed
Dec 12, 2021
sdroege
reviewed
Dec 12, 2021
All of them looks useful to me, they are either dbus or content-types |
sdroege
reviewed
Dec 12, 2021
sdroege
reviewed
Dec 12, 2021
bilelmoussaoui
force-pushed
the
bilelmoussaoui/drop-uneeded-funcs
branch
2 times, most recently
from
27e576d
to
898a7e5
Compare
To make use of RawFd types
bilelmoussaoui
force-pushed
the
bilelmoussaoui/drop-uneeded-funcs
branch
from
add8c19
to
f21e635
Compare
sdroege
reviewed
Dec 27, 2021
bilelmoussaoui
force-pushed
the
bilelmoussaoui/drop-uneeded-funcs
branch
from
27e611d
to
0799c43
Compare
bilelmoussaoui
force-pushed
the
bilelmoussaoui/drop-uneeded-funcs
branch
from
1ae7779
to
26d459b
Compare
sdroege
approved these changes
Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kind of fixes #43
There are still some stuff that could be double checked like the various logging functions but in general, it cleans up a huge part of them already