gio: use StrV for the simple proxy resolver API #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdroege
previously approved these changes
Jan 15, 2023
sdroege
reviewed
Jan 15, 2023
| @@ -1364,6 +1364,10 @@ manual_traits = ["TlsConnectionExtManual"] | |||
| name = "get_channel_binding_data" | |||
| # Gir confuses the mutability of the data | |||
| manual = true | |||
| [[object.function]] | |||
There was a problem hiding this comment.
does it make sense to manually implement this function just for this? ideally someday we will fix gir to automatically generate proper code here..
There was a problem hiding this comment.
I would rather start changing the api for the users and as soon as gir is updated we can drop the manual impls
sdroege
approved these changes
Jan 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.