New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dox feature #575

Merged
merged 1 commit into from Sep 27, 2017

Conversation

Projects
None yet
2 participants
@GuillaumeGomez
Member

GuillaumeGomez commented Sep 26, 2017

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Sep 27, 2017

Member

Thanks.

Member

EPashkin commented Sep 27, 2017

Thanks.

@GuillaumeGomez GuillaumeGomez merged commit 59562d8 into master Sep 27, 2017

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@GuillaumeGomez GuillaumeGomez deleted the dox branch Sep 27, 2017

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Sep 27, 2017

Member

I now need to do it for all other crates. Yeay...

Member

GuillaumeGomez commented Sep 27, 2017

I now need to do it for all other crates. Yeay...

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Sep 27, 2017

Member

What not works without defining dox feature in crate?
I tested only build, and it works normally on stable.

Member

EPashkin commented Sep 27, 2017

What not works without defining dox feature in crate?
I tested only build, and it works normally on stable.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Sep 27, 2017

Member

This command:

cargo doc --features "dox embed-lgpl-docs" 
Member

GuillaumeGomez commented Sep 27, 2017

This command:

cargo doc --features "dox embed-lgpl-docs" 
@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Sep 27, 2017

Member

By rust issue I thought that this feature enabled by cargo doc internally.

Member

EPashkin commented Sep 27, 2017

By rust issue I thought that this feature enabled by cargo doc internally.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Sep 27, 2017

Member

I thought as well but it isn't the case. Such disappointment...

Member

GuillaumeGomez commented Sep 27, 2017

I thought as well but it isn't the case. Such disappointment...

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Sep 27, 2017

Member

Even on nightly?

Member

EPashkin commented Sep 27, 2017

Even on nightly?

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Sep 27, 2017

Member

I only tested on nightly.

Member

GuillaumeGomez commented Sep 27, 2017

I only tested on nightly.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Sep 27, 2017

Member

Very strange 😞

Member

EPashkin commented Sep 27, 2017

Very strange 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment