subclass/widget: Implement default handling for parent events

[alatiera]

Close #916

[EPashkin]

Can this part be macro?
call_parent!(button_press_event, f(widget.to_glib_none().0, ev_glib))

[sdroege]

No because it looks different depending on what the parent class expects by default.

[EPashkin]

Ok.

[sdroege]

• parent_child_notify() should do nothing instead of panicking
• parent_compute_expand() is difficult. We need to replicate the behaviour the base class would do if it's not set here... basically we would need to set the two bools to the return values of gtk_widget_get_hexpand() and gtk_widget_get_vexpand().
• Application, container, dialog, window need the same treatment (I think all of them are cases of "do-nothing-if-not-set")

[sdroege]

Looks good, I think. Only container and widget's compute_expand() missing now :)

[alatiera]

Added compute expand now, though given how simple it looks I am not sure if that's what you had in mind?

[sdroege]

Added compute expand now, though given how simple it looks I am not sure if that's what you had in mind?

Yes exactly that. Then only the GtkContainer virtual methods are missing and then we're good to go here :)

[alatiera]

oh whoops, forgot aobut container

[sdroege]

👍

[alatiera]

Should be good to go!

[sdroege]

Should be good to go!

I agree :) Also your examples PR should be good to merge then?

[alatiera]

Okay, that's the last of the panics I am hitting it seems \o/

[sdroege]

Okay, that's the last of the panics I am hitting it seems \o/

🙌 Let's get this in then once the CI is green

[GuillaumeGomez]

Thanks!