gtk4: Use correct length for the StrV when passing to C
#1298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C doesn't want the `NUL`-terminator to be counted. Fixes gtk-rs#1297
sdroege
force-pushed
the
add-constraints-from-description-len
branch
from
b2755dd
to
6d19e11
Compare
That would make sense and be consistent with |
|
No, only that it would change the API and has to wait until the next release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C doesn't want the
NUL-terminator to be counted.CC @pbor Can you check all your commits for the same bug?
Maybe the API should be changed to not return the
NULLpointer at the end, but only return a slice of the valid elements (while still keeping theNULLpointer behind the last element). Opinions? Also @jf2048?