Add Dialog::run_async #159
Conversation
GuillaumeGomez
force-pushed
the
dialog-run
branch
from
60c5198
to
1e91667
Compare
GuillaumeGomez
force-pushed
the
dialog-run
branch
8 times, most recently
from
6f9abf8
to
15451c9
Compare
|
GuillaumeGomez
force-pushed
the
dialog-run
branch
from
15451c9
to
c355d7f
Compare
GuillaumeGomez
force-pushed
the
dialog-run
branch
from
d8e4399
to
982b5fc
Compare
|
CI passed! \o/ |
gtk4/src/dialog.rs
Outdated
| /// println!("Answer: {:?}", answer); | ||
| /// }); | ||
| /// ``` | ||
| fn run<F: FnOnce(&Self, ResponseType) + 'static>(&self, f: F); |
There was a problem hiding this comment.
Should probably be called run_async() because it's not like the original run().
There was a problem hiding this comment.
ebassi suggested response as a name, which sounds better to me instead of calling it "run"
There was a problem hiding this comment.
"response" won't work https://gtk-rs.org/gtk4-rs/gtk4/trait.DialogExt.html#tymethod.response
There was a problem hiding this comment.
Ah :/ I wonder why some signals are named "$signal_name" like the response here while others are named "emit_$signal_name" like the emit_close.
There was a problem hiding this comment.
emit_XXX() are the ones we autogenerated if a signal is marked as action signal. response() has a emission function in C that is named like that.
GuillaumeGomez
force-pushed
the
dialog-run
branch
from
dc244a7
to
c6933c4
Compare
|
@bilelmoussaoui This is ok then? |
|
Looks good to me, thanks! |
Just like what we talked about in #149, here is the non-future (and non-blocking) version.
cc @sophie-h @sdroege @bilelmoussaoui