subclass: Always allow to override the vfuns of classes #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
alatiera
force-pushed
the
alatiera/subclasss-override
branch
from
975def2
to
f2f441f
Compare
|
You need to fix the .travis.yml a bit. gio/etc do not have futures/subclass features anymore. |
|
Hmm or is the failure coming from the examples repo? In that case nevermind but please submit a PR for that :) |
|
Yeah it's from the examples. Merging this one here then but please create a PR for the examples4 repo so the CI passes again. Thanks! :) |
|
done, gtk-rs/examples4#2 |
bilelmoussaoui
pushed a commit
that referenced
this pull request
Nov 4, 2020
Don't reexport prelude content
bilelmoussaoui
pushed a commit
that referenced
this pull request
Nov 4, 2020
Use https for all links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of gtk-rs/gtk#908