New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single version file #95

Merged
merged 3 commits into from May 12, 2018

Conversation

Projects
None yet
3 participants
@EPashkin
Member

EPashkin commented May 12, 2018

Apply gtk-rs/gir#599

@GuillaumeGomez, @sdroege, @antoyo, @tmiasko
At first I wanted place versions.txt to repository root,
but then I remembered that it published as separate crates, so decided make file in root of each crate.
Old place in src/auto IMHO not good as it don't covered tests directory.

@EPashkin EPashkin changed the title from WIP: Single version file to Single version file May 12, 2018

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin May 12, 2018

Member

Updated with latest gir
PR is ready to merge, if we do not decide use single version file in repository root.

Member

EPashkin commented May 12, 2018

Updated with latest gir
PR is ready to merge, if we do not decide use single version file in repository root.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez May 12, 2018

Member

Seems good to me!

Member

GuillaumeGomez commented May 12, 2018

Seems good to me!

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege May 12, 2018

Member

Go for it

Member

sdroege commented May 12, 2018

Go for it

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez May 12, 2018

Member

Considering that there is no code changes properly speaking, I'll just go ahead and merge it. Thanks @EPashkin!

Member

GuillaumeGomez commented May 12, 2018

Considering that there is no code changes properly speaking, I'll just go ahead and merge it. Thanks @EPashkin!

@GuillaumeGomez GuillaumeGomez merged commit ad0d9dc into gtk-rs:master May 12, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details

@EPashkin EPashkin deleted the EPashkin:single_version_file branch May 12, 2018

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin May 12, 2018

Member

Maybe also better make "version.txt" location in "src" not in "src/auto" default in sys mode?

Member

EPashkin commented May 12, 2018

Maybe also better make "version.txt" location in "src" not in "src/auto" default in sys mode?

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin May 12, 2018

Member

Ops, I meant not in "src" but in target dir (as current single_version_file = ".")

Member

EPashkin commented May 12, 2018

Ops, I meant not in "src" but in target dir (as current single_version_file = ".")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment