Initial Shape API #300
Merged
Initial Shape API #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Several of our users have their own wrapper functions around our protobuf-based shape API. I think we should provide the a shape wrapper API to scrimmage developers to reduce code across plugins and repos. I didn't write wrapper functions for each shape yet because I wanted to get feedback before completing the API. |
|
Looks good, although did you mean for the first function to be "make_state" as opposed to "make_arrow"? Also, do you think we could add a general "make_shape" function that creates a shape with sensible defaults, and maybe takes in a color? 99% of the time I make a shape, I want persistent(true) and opacity to be 1.0, but protobuf defaults those to off. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.