Skip to content

Commit

Permalink
Fix guacrest docker compose healthchecks (#2001)
Browse files Browse the repository at this point in the history
* Fix guacrest healthcheck in Docker Compose files

- The health check was trying to use the HEAD method,
  but guacrest's /healthz endpoint only supports GET.
  So we just switch it to use HEAD.

Signed-off-by: Narsimham Chelluri (Narsa) <narsa@kusari.dev>

* Fix typo in Makefile comment

Signed-off-by: Narsimham Chelluri (Narsa) <narsa@kusari.dev>

---------

Signed-off-by: Narsimham Chelluri (Narsa) <narsa@kusari.dev>
  • Loading branch information
nchelluri committed Jul 7, 2024
1 parent 9a20f1e commit 41970b6
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ container: check-docker-tool-check check-docker-buildx-tool-check check-goreleas
$(LOCAL_IMAGE_NAME)
@echo "\nThe guac container image is tagged locally as $(LOCAL_IMAGE_NAME)"

# To run the service, run `make container` and then `make service`
# To run the service, run `make container` and then `make start-service`
# making the container is a longer process and thus not a dependency of service.
.PHONY: start-service
start-service: check-docker-compose-tool-check
Expand Down
2 changes: 1 addition & 1 deletion container_files/guac-demo-compose.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ services:
[
"CMD",
"wget",
"--spider",
"-O-",
"http://localhost:8081/healthz"
]
interval: 10s
Expand Down
2 changes: 1 addition & 1 deletion docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ services:
[
"CMD",
"wget",
"--spider",
"-O-",
"http://localhost:8081/healthz"
]
interval: 10s
Expand Down

0 comments on commit 41970b6

Please sign in to comment.