Fix guacrest docker compose healthchecks #2001
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the PR
In
main
right now, if you runmake container
followed bymake start-service
from the root dir, orGUAC_IMAGE=local-organic-guac docker compose -f guac-demo-compose.yaml up --force-recreate
from thecontainer_files
dir, and then rundocker ps
,guacrest
will be reported as unhealthy.This is because the healthcheck uses the
wget
's--spider
flag which makes a HEAD request. But the OpenAPI spec forguacrest
does not allow for that method. So I changed the healthcheck command to use thewget
's-O-
flag instead, which makes a GET request (and doesn't create a file with the response body - which would happen without any-O
flag - but instead prints it to standard out).After my commits, I retested the above
docker compose
commands and in both casesdocker ps
showsguacrest
as healthy.fixes #2002
PR Checklist
-s
flag togit commit
.make generate
has been runmake generate
has been runmake generate
has been runcollectsub
protobuf has been changed,make proto
has been run