Including the Scorecard API #1938
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pxp928
reviewed
May 31, 2024
nathannaveen
reviewed
Jun 3, 2024
- Fixes guacsec#1892 - Updated tests - Added a README for certifier/scorecard Signed-off-by: neilnaveen <42328488+neilnaveen@users.noreply.github.com>
neilnaveen
force-pushed
the
neil/use-scorecard-api
branch
from
2efba9f
to
2db7b2b
Compare
Signed-off-by: neilnaveen <42328488+neilnaveen@users.noreply.github.com>
Signed-off-by: neilnaveen <42328488+neilnaveen@users.noreply.github.com>
lumjjb
requested changes
Jul 9, 2024
| @@ -26,7 +26,7 @@ type Certifier interface { | |||
| // push to the docChannel to be ingested. | |||
| // Note: there is an implicit contract with "QueryComponents" where the compChan type must be the same as | |||
| // the one used by "components" | |||
| CertifyComponent(ctx context.Context, components interface{}, docChannel chan<- *processor.Document) error | |||
| CertifyComponent(ctx context.Context, components interface{}, docChannel chan<- *processor.Document, useScorecardAPI bool) error | |||
There was a problem hiding this comment.
there shouldn't be a scorecard specific flag for the ceritfier interface, things that are specific to the certifier should be part of the initialization of the certifier. Maybe this is something that should be part of RegisterCertifier.
| @@ -0,0 +1,29 @@ | |||
| # Scorecard Certifier | |||
|
This pull request has been automatically marked as stale because it has not had recent activity (60 days of inactivity). |
|
ping to keep it from closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the PR
PR Checklist
-sflag togit commit.make generatehas been runmake generatehas been runcollectsubprotobuf has been changed,make protohas been run