Feature/1116 arango verb mutation #1529

pxp928 · 2023-11-25T03:52:12Z

Description of the PR

Complete all verbs mutations to return only IDs

closes #1197

PR Checklist

All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
All new changes are covered by tests
If GraphQL schema is changed, make generate has been run
If collectsub protobuf has been changed, make proto has been run
All CI checks are passing (tests and formatting)
All dependent PRs have already been merged

Signed-off-by: pxp928 <parth.psu@gmail.com>

pxp928 · 2023-11-25T04:00:49Z

Arango tests all pass. Ent tests can be updated in a future PR.

Signed-off-by: pxp928 <parth.psu@gmail.com>

jeffmendoza

epic!

Signed-off-by: pxp928 <parth.psu@gmail.com>

… main) (#1542) * Backend interface - Methods for returning 'string' (#1285) Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: pxp928 <parth.psu@gmail.com> * Enable GitHub CI tests (#1296) * Enable GitHub CI tests Signed-off-by: mrizzi <mrizzi@redhat.com> * Mocks backend updated Signed-off-by: mrizzi <mrizzi@redhat.com> * Ent - Bump v0.12.4-0.20230918073025-797534a0d1ca (#1283) * Ent - Bump v0.12.4-0.20230918073025-797534a0d1ca Signed-off-by: mrizzi <mrizzi@redhat.com> * Ent - Pin postgres image to hash Signed-off-by: mrizzi <mrizzi@redhat.com> --------- Signed-off-by: mrizzi <mrizzi@redhat.com> --------- Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: pxp928 <parth.psu@gmail.com> * Ent - IngestArtifactID,IngestArtifactIDs implementations (#1300) Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: pxp928 <parth.psu@gmail.com> * Ent - IngestBuilderID, IngestPackageID, IngestSourceID, IngestVulnerabilityID (#1329) * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * Ent - upsertPackageIDDoNothing vs upsertPackageIDIgnore (#1270) * Ent - upsertPackageIDDoNothing vs upsertPackageIDIgnore Signed-off-by: mrizzi <mrizzi@redhat.com> * Ent - final upsertPackage implementation Signed-off-by: mrizzi <mrizzi@redhat.com> --------- Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: desmax74 <mdessi@redhat.com> * Ent - upsertPackage: enhanced ID management Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * Ent - Packages: subpath query issue (#1330) * Ent - Packages: subpath query issue reproducer Signed-off-by: mrizzi <mrizzi@redhat.com> * Ent - Packages: subpath query issue fix Signed-off-by: mrizzi <mrizzi@redhat.com> --------- Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * Ent - TestIngestVulnerabilities changes to support ID Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * Ent - Node: added SourceName management Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> --------- Signed-off-by: desmax74 <mdessi@redhat.com> Signed-off-by: mrizzi <mrizzi@redhat.com> Co-authored-by: Marco Rizzi <mrizzi@users.noreply.github.com> Co-authored-by: mrizzi <mrizzi@redhat.com> Signed-off-by: pxp928 <parth.psu@gmail.com> * Ent - IngestHasSBOMID (#1470) Signed-off-by: desmax74 <mdessi@redhat.com> Signed-off-by: pxp928 <parth.psu@gmail.com> * Ent - ScorecardID (#1469) Signed-off-by: desmax74 <mdessi@redhat.com> Signed-off-by: pxp928 <parth.psu@gmail.com> * Ent - PkgEqualsID (#1473) Signed-off-by: desmax74 <mdessi@redhat.com> Signed-off-by: pxp928 <parth.psu@gmail.com> * update ent IngestHasSbomID and IngestHasSBOMIDs with the new includes field Signed-off-by: pxp928 <parth.psu@gmail.com> * Feature/1116 arango noun mutation update to return only IDs (#1511) * change artifact mutation to return only ID Signed-off-by: pxp928 <parth.psu@gmail.com> * change builder and license to return only ID during ingestion Signed-off-by: pxp928 <parth.psu@gmail.com> * update package to return flat struct of IDs Signed-off-by: pxp928 <parth.psu@gmail.com> * update source and vulnerability to return mutation ID Signed-off-by: pxp928 <parth.psu@gmail.com> * update ENT for vulnerability and package mutation IDs Signed-off-by: pxp928 <parth.psu@gmail.com> * update ENT for source mutation IDs Signed-off-by: pxp928 <parth.psu@gmail.com> * update tests for arango and ent Signed-off-by: pxp928 <parth.psu@gmail.com> --------- Signed-off-by: pxp928 <parth.psu@gmail.com> * Update all resolvers for Return ID (#1514) * Update resolvers to use ID backend methods Signed-off-by: Jeff Mendoza <jlm@jlm.name> * Remove old methods from backend interface, update pkg/src/vuln resolvers. Signed-off-by: Jeff Mendoza <jlm@jlm.name> --------- Signed-off-by: Jeff Mendoza <jlm@jlm.name> Signed-off-by: pxp928 <parth.psu@gmail.com> * Update keyvalue backend to return ID (#1524) * Update keyvalue backend to return ID Signed-off-by: Jeff Mendoza <jlm@jlm.name> * Lint gosimple Signed-off-by: Jeff Mendoza <jlm@jlm.name> * Regen backend mock Signed-off-by: Jeff Mendoza <jlm@jlm.name> --------- Signed-off-by: Jeff Mendoza <jlm@jlm.name> Signed-off-by: pxp928 <parth.psu@gmail.com> * Feature/1116 arango verb mutation (#1529) Signed-off-by: pxp928 <parth.psu@gmail.com> * Complete Ent Return -ID (#1536) * Updated ent with ID Signed-off-by: Jeff Mendoza <jlm@jlm.name> * Update ent tests for ID. Signed-off-by: Jeff Mendoza <jlm@jlm.name> --------- Signed-off-by: Jeff Mendoza <jlm@jlm.name> Signed-off-by: pxp928 <parth.psu@gmail.com> * change mutations back to original name (#1541) Signed-off-by: pxp928 <parth.psu@gmail.com> * remove branch from ci workflow Signed-off-by: pxp928 <parth.psu@gmail.com> --------- Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: pxp928 <parth.psu@gmail.com> Signed-off-by: desmax74 <mdessi@redhat.com> Signed-off-by: Jeff Mendoza <jlm@jlm.name> Co-authored-by: Marco Rizzi <mrizzi@users.noreply.github.com> Co-authored-by: Massimiliano Dessì - (Fast Chauffeur) <desmax74@users.noreply.github.com> Co-authored-by: mrizzi <mrizzi@redhat.com> Co-authored-by: Jeff Mendoza <jlm@jlm.name>

pxp928 added 14 commits November 21, 2023 15:26

update certifyBad and certifyGood mutations

91dc5c1

Signed-off-by: pxp928 <parth.psu@gmail.com>

update certifyLegal mutations to return only IDs

c555cc0

Signed-off-by: pxp928 <parth.psu@gmail.com>

update scorecard mutations to return only IDs

748edeb

Signed-off-by: pxp928 <parth.psu@gmail.com>

update vex mutations to return only IDs

558d314

Signed-off-by: pxp928 <parth.psu@gmail.com>

update certifyVuln mutations to return only IDs

7db1f04

Signed-off-by: pxp928 <parth.psu@gmail.com>

update hashEqual mutations to reuturn only IDs

27dd4d8

Signed-off-by: pxp928 <parth.psu@gmail.com>

update hasMetadata mutations to return only IDs

3285bfa

Signed-off-by: pxp928 <parth.psu@gmail.com>

update hasSBOM and hasSLSA mutations to return only IDs

6fa7390

Signed-off-by: pxp928 <parth.psu@gmail.com>

update hasSourceAt mutations to return only IDs

62ee76e

Signed-off-by: pxp928 <parth.psu@gmail.com>

update isDep mutations to return only IDs

767db97

Signed-off-by: pxp928 <parth.psu@gmail.com>

update isOcur mutations to return only IDs

a627964

Signed-off-by: pxp928 <parth.psu@gmail.com>

update pkgEqual mutations to return only IDs

120aaf4

Signed-off-by: pxp928 <parth.psu@gmail.com>

udpate poc mutations to return only IDs

7da9548

Signed-off-by: pxp928 <parth.psu@gmail.com>

update vulnEqual and vulnMetadata mutations to return only IDs

3bf5054

Signed-off-by: pxp928 <parth.psu@gmail.com>

pxp928 requested a review from mihaimaruseac as a code owner November 25, 2023 03:52

pull-request-size bot added the size/XXL label Nov 25, 2023

pxp928 mentioned this pull request Nov 25, 2023

[feature - arango] Change all backend mutation implementations to return only ID #1197

Closed

pxp928 requested a review from jeffmendoza November 25, 2023 04:03

update path unit tests

ef7bcce

Signed-off-by: pxp928 <parth.psu@gmail.com>

pxp928 force-pushed the feature/1116-arango-verb-mutation branch from 1f2c825 to ef7bcce Compare November 25, 2023 04:09

jeffmendoza approved these changes Nov 25, 2023

View reviewed changes

mihaimaruseac approved these changes Nov 25, 2023

View reviewed changes

pxp928 merged commit acc86cc into guacsec:1116-return-ID Nov 25, 2023
7 of 8 checks passed

pxp928 added a commit that referenced this pull request Nov 30, 2023

Feature/1116 arango verb mutation (#1529)

c5b148f

pxp928 added a commit that referenced this pull request Nov 30, 2023

Feature/1116 arango verb mutation (#1529)

79818ea

Signed-off-by: pxp928 <parth.psu@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/1116 arango verb mutation #1529

Feature/1116 arango verb mutation #1529

pxp928 commented Nov 25, 2023 •

edited

Loading

pxp928 commented Nov 25, 2023

jeffmendoza left a comment

Feature/1116 arango verb mutation #1529

Feature/1116 arango verb mutation #1529

Conversation

pxp928 commented Nov 25, 2023 • edited Loading

Description of the PR

PR Checklist

pxp928 commented Nov 25, 2023

jeffmendoza left a comment

Choose a reason for hiding this comment

pxp928 commented Nov 25, 2023 •

edited

Loading